Skip to content

Only check c/c++ files with clang-format pre-commit #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

alexander-novo
Copy link
Collaborator

Description

Fixes #120

Proposed changes

Make sure to only run clang-format on C/C++ files.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here
to help! This is simply a reminder of what we are going to look for before
merging your code.

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@alexander-novo alexander-novo added the development Features/Tools related to development of GridKit, rather than use as a library. label May 29, 2025
@pelesh pelesh merged commit 30c5432 into develop May 30, 2025
3 checks passed
@pelesh pelesh deleted the fix-clang-format-ci branch June 10, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Features/Tools related to development of GridKit, rather than use as a library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull Request CI fails when pull requests include non-C++ files
3 participants